Focal Point
[CLOSED] Variable assignment problem

This topic can be found at:
https://forums.informationbuilders.com/eve/forums/a/tpc/f/7971057331/m/1427010296

November 18, 2019, 10:29 AM
Wep5622
[CLOSED] Variable assignment problem
We have (part of) some code that gets values from a database field and logs that to a file.
It turns out that in some rare occasions, the field ends with newline+carriage return, and that breaks our Dialog Manager code.

Example:
-* Simulate data from database
-* Normally called with:  EX dw_logParameter PARM='TUPLE',TUPLE=&TUPLE.QUOTEDSTRING 
-SET &PARM = 'TUPLE';
-SET &TUPLE = 'Frobblemox' || HEXBYT(13, 'A1') || HEXBYT(10, 'A1');

-* dw_logParameter.fex
-SET &PVAR = '&' || &PARM;
-SET &PVAL = RTRIM(&PVAR.EVAL);
-SET &_MESSAGE = &PARM || '=' || &PVAL.QUOTEDSTRING;

-TYPE &_MESSAGE


Which results in:
quote:
 0 NUMBER OF RECORDS IN TABLE=        0  LINES=      0
 0 ERROR AT OR NEAR LINE     39  IN PROCEDURE ADHOCRQ FOCEXEC *
 (FOC257) MISSING QUOTE MARKS: 'Frobblemox


Is there any way to catch this in the breaking code?

The text causing the issue is part of the primary key of a table; modifying the value on read would break references to the records in this table.

I could exclude this data, the rows are marked with a 'Cancelled' status, but sometimes that is relevant information, so I consider that among the last resorts.

This message has been edited. Last edited by: FP Mod Chuck,


WebFOCUS 8.1.03, Windows 7-64/2008-64, IBM DB2/400, Oracle 11g & RDB, MS SQL-Server 2005, SAP, PostgreSQL 11, Output: HTML, PDF, Excel 2010
: Member of User Group Benelux :
November 18, 2019, 01:16 PM
MartinY
Does this is good for you Wep ?
-* Simulate data from database
-* Normally called with:  EX dw_logParameter PARM='TUPLE',TUPLE=&TUPLE.QUOTEDSTRING 
-SET &PARM = 'TUPLE';
-SET &TUPLE = '''' || 'Frobblemox' || HEXBYT(13, 'A1') || HEXBYT(10, 'A1') || '''';

-* dw_logParameter.fex
-SET &PVAR = '&' || &PARM;
-SET &PVAL = RTRIM(&PVAR.EVAL);
-SET &_MESSAGE = &PARM || '=' || &PVAL.QUOTEDSTRING;

-TYPE &_MESSAGE




WF versions : Prod 8.2.04M gen 33, Dev 8.2.04M gen 33, OS : Windows, DB : MSSQL, Outputs : HTML, Excel, PDF
In Focus since 2007
November 19, 2019, 11:34 AM
Wep5622
Interesting idea to add extra quotes at the procedure calling parameter.

Unfortunately, it would change the output relative to previous output; we eventually store the result in a database table. I'm not too worried about the backwards compatibility there, though.

I would prefer to fix that procedure parameter value within the procedure. After all, the procedure accepted the parameter value, it should be able to use it!

Well, at least if that turns out to be impossible, I have a workaround. Thanks.


WebFOCUS 8.1.03, Windows 7-64/2008-64, IBM DB2/400, Oracle 11g & RDB, MS SQL-Server 2005, SAP, PostgreSQL 11, Output: HTML, PDF, Excel 2010
: Member of User Group Benelux :
November 20, 2019, 01:42 PM
Hallway
What about trimming off the TRAILING line feed after the RTRIM?
  
-* Simulate data from database
-* Normally called with:  EX dw_logParameter PARM='TUPLE',TUPLE=&TUPLE.QUOTEDSTRING 
-SET &PARM = 'TUPLE';
-SET &TUPLE = 'Frobblemox' || HEXBYT(13, 'A1') || HEXBYT(10, 'A1');

-* dw_logParameter.fex
-SET &PVAR = '&' || &PARM;
-SET &PVAL = TRIM_(TRAILING, HEXBYT(10, 'A1'), RTRIM(&PVAR.EVAL));
-SET &_MESSAGE = &PARM || '=' || &PVAL.QUOTEDSTRING;

-TYPE &_MESSAGE


That gave me:
quote:

 PVAL 'Frobblemox'
 TUPLE=Frobblemox  




Hallway

 
Prod: 8202M1
Test: 8202M4
Repository:
 
OS:
 
Outputs: