• Single line JOIN's that end with END.
  
• Multiple -DEFAULT's for the same parameter (especially problematic when using -INCLUDE).
  
• SQL blocks starting with a TAB character (often that just works, but then suddenly it doesn't - not sure what's going on there).
  
• Indented DM code where the - (minus) is not at position 0 in the line.
  
• Indented comments (similar to above, but asterisk can't be indented).
  

quote:

Indented comments (similar to above, but asterisk can't be indented).

 COMPUTE SOMETHING/A1 = 'X'; -* this comment is syntactically correct from version 8.something

-TYPE **************************************************************************************************************
-TYPE *** IBFS:/Dev/WFC/Repository/Vendor/KPIs/&FOCFEXNAME.EVAL.fex *** Start &TOD ***
. . . comments . . .
-TYPE **************************************************************************************************************

-RUN
-SET &TOD=HHMMSS('A8') ;
-TYPE **************************************************************************************************************
-TYPE *** IBFS:/Dev/WFC/Repository/Vendor/KPIs/&FOCFEXNAME.EVAL.fex *** Ended &TOD ***
-TYPE **************************************************************************************************************

quote:

False use of .EVAL

quote:

How about any line that has nothing but a dash -

I remember it well...

quote:

I'm waiting for Francis to suggest "anything written outside of the GUI"

Waz...

Prod:	WebFOCUS 7.6.10/8.1.04	Upgrade:	WebFOCUS 8.2.07	OS:	Linux	Outputs:	HTML, PDF, Excel, PPT
In Focus since 1984
Pity the lost knowledge of an old programmer!

quote:

I like to add a -TYPE statement in my flower boxes at the start

Waz...

Prod:	WebFOCUS 7.6.10/8.1.04	Upgrade:	WebFOCUS 8.2.07	OS:	Linux	Outputs:	HTML, PDF, Excel, PPT
In Focus since 1984
Pity the lost knowledge of an old programmer!

quote:

Double semi-colons at the end of DEFINEs: ;;

quote:

Originally posted by Waz:
Wondering how I would detect false use of .EVAL

ON TABLE HOLD AS &HOLDFILE.EVAL
-INCLUDE &FEX.EVAL

-SET &FEX = '-INCLUDE fex.fex';
&FEX.EVAL

quote:

is your code validator written in FOCUS?

Waz...

Prod:	WebFOCUS 7.6.10/8.1.04	Upgrade:	WebFOCUS 8.2.07	OS:	Linux	Outputs:	HTML, PDF, Excel, PPT
In Focus since 1984
Pity the lost knowledge of an old programmer!

quote:

I think the very nature of .EVAL makes it hard, if not impossible

Waz...

Prod:	WebFOCUS 7.6.10/8.1.04	Upgrade:	WebFOCUS 8.2.07	OS:	Linux	Outputs:	HTML, PDF, Excel, PPT
In Focus since 1984
Pity the lost knowledge of an old programmer!

quote:

quote:
Indented comments (similar to above, but asterisk can't be indented).

Shouldn't be an issue?

COMPUTE SOMETHING/A1 = 'X'; -* this comment is syntactically correct from version 8.something

-SET &ECHO=ALL;

-* correct syntax 1
 -* correct syntax 2
  -* correct syntax 3
   -* correct syntax 4
    -* correct syntax 5
     -* correct syntax 6

-SET &Set = 'Test' ; -* Set Command

DEFINE FILE SYSTABLE
 Name/A100V = Name ; -* DefField
END

Waz...

Prod:	WebFOCUS 7.6.10/8.1.04	Upgrade:	WebFOCUS 8.2.07	OS:	Linux	Outputs:	HTML, PDF, Excel, PPT
In Focus since 1984
Pity the lost knowledge of an old programmer!

/* 
    SearchReplace is a utility app I created to give users the ability to search any directory on their PC
    and all that directory's subdirectories for anything they are searching for within the files found therein.

    The program will ask the user for the root directory to search in, which files to search in, and which strings
    to use to search for and replace with.

    Author:  Anthony Cool
    Created: 10/26/2017
*/

using System;
using System.IO;

namespace SearchReplace
{
    class Program
    {
        static void Main(string[] args)
        {
            // C:\pathToSearchDirectory\..

            string rootDirectory = "";

            // Welcome and ask user what folder to search in:
            Console.WriteLine("\nWelcome to SearchReplace.\n\n"
                            + "What's the full path to the directory to search in?\n");
            // Store response:
            try {
                rootDirectory = @Console.ReadLine();
                // If user fails to give a directory/folder, set to something to exit app smoothly:
                if(rootDirectory == null || rootDirectory == "") {
                    rootDirectory = "YOU DID NOT GIVE A DIRECTORY TO SEARCH WITHIN";
                }
                // Set directory given to current directory to check if valid:
                Directory.SetCurrentDirectory(rootDirectory);
            }
            catch (DirectoryNotFoundException dirEx) {
                    // Let the user know that the directory did not exist:
                    Console.WriteLine("The directory does not exist. Details: " + dirEx.Message);
                    Environment.Exit(0);
            }

            // Ask user what file pattern to restrict the search to:
            Console.WriteLine("\nWhen we search your directory, which file names & types would you like to search in?\n"
                            + "This is specified by giving a pattern.  * means 0 or more chars, while ? means 0 or 1 chars.\n"
                            + "Example:  *.* = all names & types, *.fex = all fex files regardless of names, etc.\n");
            // Store response:
            string searchPattern = @Console.ReadLine();

            // Ask user which string to search for:
            Console.WriteLine("\nWhat string should be searched for and replaced?\n");
            // Store response:
            string searchString = @Console.ReadLine();

            // Ask user what string should replace the search string:
            Console.WriteLine("\nWhat string should replace the string we're searching for?\n");
            // Store response:
            string replacementString = @Console.ReadLine();

            // Gather all the files in the root directory and its subdirectories and store them to be looped through:
            var files = Directory.EnumerateFiles(rootDirectory, searchPattern, SearchOption.AllDirectories);
            // Loop through every file found above:
            foreach (string file in files) {
                try {
                    // If the file contains the string to be replaced:
                    if(File.ReadAllText(file).Contains(searchString) == true){
                        // Read the text from the file and store it:
                        string contents = File.ReadAllText(file);
                        // Replace search string with replacement string (using .NET Core 2.0+ overload):
                        contents = contents.Replace(searchString, replacementString, StringComparison.OrdinalIgnoreCase);
                        // Make file writable if it isn't already:
                        File.SetAttributes(file, FileAttributes.Normal);
                        // Overwrite the file with the changes made:
                        File.WriteAllText(file, contents);
                    }
                    else {
                        // Skip the file and move to the next file:
                        continue;
                    }
                }
                catch (Exception ex) { 
                    Console.WriteLine("Sorry. The following error has occurred:\n\n" + ex.Message);
                }
            }
            // State that the text replacements have been made:
            Console.WriteLine("\nThank you for your patience.\n\n"
                             + "\"" + searchString + "\"" + " has been fully replaced with " + "\"" + replacementString + "\".");
            // Pause the program before exiting so the end user can read the above message beforehand:
            Console.ReadLine();
        }
    }
}

quote:

CoolGuy has a first name.